fix(helm): use correct templating for mcpClientConfig (#2673)#8
Merged
dominictayloruk merged 1 commit intodominictayloruk:mainfrom Apr 13, 2026
Merged
fix(helm): use correct templating for mcpClientConfig (#2673)#8dominictayloruk merged 1 commit intodominictayloruk:mainfrom
dominictayloruk merged 1 commit intodominictayloruk:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Bifrost Helm chart to version 2.0.18. The primary change involves fixing the MCP client configuration template in _helpers.tpl to correctly map camelCase keys from Helm values (toolsToExecute, toolsToAutoExecute, authType, and oauthConfigId) to their corresponding snake_case keys in the generated configuration. The Chart.yaml, README.md, and index.yaml files have been updated to reflect this version bump and include the relevant changelog entry. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Briefly explain the purpose of this PR and the problem it solves.
Changes
Type of change
Affected areas
How to test
Describe the steps to validate this change. Include commands and expected outcomes.
If adding new configs or environment variables, document them here.
Screenshots/Recordings
If UI changes, add before/after screenshots or short clips.
Breaking changes
If yes, describe impact and migration instructions.
Related issues
Link related issues and discussions. Example: Closes maximhq#123
Security considerations
Note any security implications (auth, secrets, PII, sandboxing, etc.).
Checklist
docs/contributing/README.mdand followed the guidelines